ci(semgrep): add pre-commit hook with default ruleset#272
Open
wajidzahoor-dls wants to merge 2 commits intomainfrom
Open
ci(semgrep): add pre-commit hook with default ruleset#272wajidzahoor-dls wants to merge 2 commits intomainfrom
wajidzahoor-dls wants to merge 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
=======================================
Coverage 90.37% 90.37%
=======================================
Files 68 68
Lines 2368 2368
=======================================
Hits 2140 2140
Misses 228 228 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7b46f15 to
2852b6a
Compare
2852b6a to
96b006f
Compare
Contributor
|
I have fixed some findings and ignored others, so it is passing now. The problem I have with this is it is very slow. Taking between 30 and 90 seconds it definitely can't be a pre-commit hook. Could we have it just as CI instead? Is there any way to speed it up? I am also quite confused by the output. It seems to run 4 independent scans and report the findings separately, so it is quite hard to read. Is this a configuration problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
p/default) for broad multi-language coverage.--error).Only the pre-commit configuration is updated; no application code changes are included.
How to test
Testing depends on your environment:
To manually verify Semgrep runs:
This should report findings if any tracked files violate rules.
Optional spot check
Create a temporary file, for example
tmp_bad.py, that contains a few intentionally unsafe patterns such as:Then add and commit the file; the Semgrep pre-commit hook should run automatically and report findings.
Remove the file afterwards.
Notes
# nosemgrep(and other inline ignore directives) as described in the Semgrep docs: https://semgrep.dev/docs/ignoring-files-folders-code/Reviewer checks
.pre-commit-config.yaml